Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlertModal title incorrectly styled as h4 vs. h3 #3129

Open
adamstankiewicz opened this issue Jul 10, 2024 · 0 comments
Open

AlertModal title incorrectly styled as h4 vs. h3 #3129

adamstankiewicz opened this issue Jul 10, 2024 · 0 comments
Labels
bug Report of or fix for something that isn't working as intended design Design

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Jul 10, 2024

Bugs

The ModalDialog.Title component used within AlertModal is an h2 element styled as a h4 (source), despite Paragon's Figma library showing it styled as an h3 like the other modal component variants (e.g., StandardDialog, ModalDialog).

It appears the AlertModal title has had the discrepancy between Figma and the implemented code discrepancy since it was originally introduced in April 2021. Unsure if there was a specific rationale for this (assuming it was intentional), and/or whether the Figma changed after the original implementation.

Implemented (code)

Heading is styled as h4 (i.e., 18px for @edx/brand-edx.org's base font size)

image

Figma (mock)

Heading is styled as h3 (i.e., 22px for @edx/brand-edx.org's base font size)

image image
@adamstankiewicz adamstankiewicz added bug Report of or fix for something that isn't working as intended design Design labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended design Design
Projects
Status: Backlog
Development

No branches or pull requests

1 participant