You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ModalDialog.Title component used within AlertModal is an h2 element styled as a h4 (source), despite Paragon's Figma library showing it styled as an h3 like the other modal component variants (e.g., StandardDialog, ModalDialog).
It appears the AlertModal title has had the discrepancy between Figma and the implemented code discrepancy since it was originally introduced in April 2021. Unsure if there was a specific rationale for this (assuming it was intentional), and/or whether the Figma changed after the original implementation.
Implemented (code)
Heading is styled as h4 (i.e., 18px for @edx/brand-edx.org's base font size)
Bugs
The
ModalDialog.Title
component used withinAlertModal
is anh2
element styled as ah4
(source), despite Paragon's Figma library showing it styled as anh3
like the other modal component variants (e.g.,StandardDialog
,ModalDialog
).It appears the
AlertModal
title has had the discrepancy between Figma and the implemented code discrepancy since it was originally introduced in April 2021. Unsure if there was a specific rationale for this (assuming it was intentional), and/or whether the Figma changed after the original implementation.Implemented (code)
Heading is styled as
h4
(i.e., 18px for@edx/brand-edx.org
's base font size)Figma (mock)
Heading is styled as
h3
(i.e., 22px for@edx/brand-edx.org
's base font size)The text was updated successfully, but these errors were encountered: