-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add python 3.11 support #78
Conversation
Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 5 5
Lines 622 622
Branches 87 81 -6
=======================================
Hits 611 611
Misses 5 5
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@feanil The tests are green now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the requirements have been updated using python 3.11
env. To keep the Python 3.8
compatibility, we should run make upgrade
inside python 3.8
env for now.
@UsamaSadiq have updated accordingly |
@ichintanjoshi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR contains changes for upgrading python 3.8 to python 3.11.
Changes include :-
fractions
function in miller.py file usedfr.gcd
Done as a part of following :-