-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update links in head and *isLoaded to true #534
fix: update links in head and *isLoaded to true #534
Conversation
Thanks for the pull request, @monteri! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## ags/inject-theme-css #534 +/- ##
========================================================
- Coverage 79.05% 78.31% -0.74%
========================================================
Files 48 48
Lines 1351 1365 +14
Branches 283 286 +3
========================================================
+ Hits 1068 1069 +1
- Misses 251 262 +11
- Partials 32 34 +2
☔ View full report in Codecov by Sentry. |
Hi @monteri! Just flagging that there's a couple failing checks. |
@mphilbrick211 Hello, thank you for the ping! It is PR into the another PR. On the point of the failing checks I will discuss next steps with @adamstankiewicz |
Hi @monteri - could you try rebasing this PR? It might help the codecov checks pass. If it doesn't work, I'll look into it for you. |
Hey @monteri, What is the current status of this PR, is it ready to review and merge? |
8f0edb4
into
openedx:ags/inject-theme-css
@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Co-authored-by: monteri <lansevermore>
Co-authored-by: monteri <lansevermore>
Co-authored-by: monteri <lansevermore>
fix: update links in head and *isLoaded to true (openedx#534) Co-authored-by: monteri <lansevermore>
Co-authored-by: monteri <lansevermore>
Description:
Describe what this pull request changes, and why. Include implications for people using this change.
Merge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: