-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test to useParagonTheme hook and paragon utils #525
test: add test to useParagonTheme hook and paragon utils #525
Conversation
Thanks for the pull request, @dcoa! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## ags/inject-theme-css #525 +/- ##
========================================================
+ Coverage 79.05% 82.45% +3.40%
========================================================
Files 48 48
Lines 1351 1351
Branches 283 283
========================================================
+ Hits 1068 1114 +46
+ Misses 251 217 -34
+ Partials 32 20 -12 ☔ View full report in Codecov by Sentry. |
Hi @dcoa - is this ready for review? cc: @adamstankiewicz |
Hi @mphilbrick211, yes, it is |
Hi @openedx/fed-bom! Would someone be able to review / merge this for us? |
it('should remove all the links in the DOM', () => { | ||
document.head.innerHTML = ` | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@edx/paragon@$21.0.0/dist/core.min.css"> | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@edx/brand@$2.0.0Version/dist/core.min.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the version in this href
URL is incorrectly formatted, i.e. $2.0.0Version
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I fixed it, thanks
Hi, @adamstankiewicz, any additional feedback? |
Hi @adamstankiewicz! Friendly ping on this. |
Hi @openedx/fed-bom @adamstankiewicz! Is this something you could please review / merge for us? Thanks! |
Some context for FED-BOM from @adamstankiewicz :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @dcoa! Apologies for the delayed review.
@dcoa 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
This is a testing contribution to Theming Configuration in Runtime, covering useParagonTheme hook, and the utils file.
Context: #440
C.C @adamstankiewicz