Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't accidentally bundle paragon CSS x2 #487

Merged
merged 1 commit into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@import "@openedx/paragon/scss/core/core";
// do NOT @import "@openedx/paragon/scss/core/core"; in any files in this repo, or it will add 400 kB of extra CSS
// to the MFE each time you do so. The following are OK because they are only defining variables like $grey-500:
@import "@edx/brand/paragon/variables";
@import "@openedx/paragon/scss/core/_variables";

.total-label {
border: 1px solid $gray-500;
Expand Down
5 changes: 4 additions & 1 deletion src/editors/containers/VideoUploadEditor/index.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@import "@openedx/paragon/scss/core/core";
// do NOT @import "@openedx/paragon/scss/core/core"; in any files in this repo, or it will add 400 kB of extra CSS
// to the MFE each time you do so. The following are OK because they are only defining variables like $grey-500:
@import "@edx/brand/paragon/variables";
@import "@openedx/paragon/scss/core/_variables";

.dropzone-middle {
border: 2px dashed #ccc;
Expand Down
Loading