Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more/correct v2 url handling. TNL-10742 #355

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

kenclary
Copy link
Contributor

@kenclary kenclary commented Jun 22, 2023

feat: more/correct v2 url handling. TNL-10742

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (4a5eaaf) 90.26% compared to head (7178e5e) 90.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   90.26%   90.29%   +0.02%     
==========================================
  Files         226      226              
  Lines        3946     3955       +9     
  Branches      777      784       +7     
==========================================
+ Hits         3562     3571       +9     
  Misses        365      365              
  Partials       19       19              
Impacted Files Coverage Δ
src/editors/data/services/cms/api.js 98.90% <ø> (ø)
src/editors/containers/EditorContainer/hooks.js 100.00% <100.00%> (ø)
src/editors/data/services/cms/urls.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenclary kenclary changed the title feat: more/better v2 url handling (incomplete). TNL-10743 feat: more/better v2 url handling. TNL-10743 Jun 23, 2023
@kenclary kenclary force-pushed the kenclary/TNL-10743 branch 6 times, most recently from 6f42319 to 87be759 Compare June 28, 2023 19:37
@kenclary kenclary force-pushed the kenclary/TNL-10743 branch 5 times, most recently from fb6259e to b6381fe Compare July 13, 2023 14:31
@kenclary kenclary changed the title feat: more/better v2 url handling. TNL-10743 feat: more/correct v2 url handling. TNL-10742 Jul 13, 2023
@kenclary kenclary marked this pull request as ready for review July 13, 2023 14:32
Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for taking that into consideration

@kenclary kenclary merged commit a935d29 into main Jul 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants