From 28c7b32bd59dbd36cf5e3ad0be938131088015f1 Mon Sep 17 00:00:00 2001 From: Braden MacDonald Date: Thu, 20 Jun 2024 15:23:08 -0700 Subject: [PATCH] fix: don't accidentally bundle paragon CSS x2 --- .../VideoSettingsModal/components/DurationWidget/index.scss | 5 ++++- src/editors/containers/VideoUploadEditor/index.scss | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget/index.scss b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget/index.scss index 97769de4b..d71cf1c6e 100644 --- a/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget/index.scss +++ b/src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget/index.scss @@ -1,4 +1,7 @@ -@import "@openedx/paragon/scss/core/core"; +// do NOT @import "@openedx/paragon/scss/core/core"; in any files in this repo, or it will add 400 kB of extra CSS +// to the MFE each time you do so. The following are OK because they are only defining variables like $grey-500: +@import "@edx/brand/paragon/variables"; +@import "@openedx/paragon/scss/core/_variables"; .total-label { border: 1px solid $gray-500; diff --git a/src/editors/containers/VideoUploadEditor/index.scss b/src/editors/containers/VideoUploadEditor/index.scss index 6163d968a..6e3186204 100644 --- a/src/editors/containers/VideoUploadEditor/index.scss +++ b/src/editors/containers/VideoUploadEditor/index.scss @@ -1,4 +1,7 @@ -@import "@openedx/paragon/scss/core/core"; +// do NOT @import "@openedx/paragon/scss/core/core"; in any files in this repo, or it will add 400 kB of extra CSS +// to the MFE each time you do so. The following are OK because they are only defining variables like $grey-500: +@import "@edx/brand/paragon/variables"; +@import "@openedx/paragon/scss/core/_variables"; .dropzone-middle { border: 2px dashed #ccc;