From c4ad876f5a882ab83b5f35b40ebb6dc5dd8dfa26 Mon Sep 17 00:00:00 2001 From: Asad Ali Date: Thu, 25 Jan 2024 16:59:26 +0500 Subject: [PATCH] refactor: remove extra customizations --- .env.development | 3 --- README.rst | 36 ++++++++++++------------------------ package.json | 13 ++++++------- src/components/Footer.jsx | 2 +- 4 files changed, 19 insertions(+), 35 deletions(-) diff --git a/.env.development b/.env.development index 765777edd8..1600852456 100644 --- a/.env.development +++ b/.env.development @@ -23,9 +23,7 @@ LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico ABOUT_US_URL= -PRIVACY_POLICY_URL= HONOR_CODE_URL= -TERMS_OF_SERVICE_URL= CONTACT_URL= SUPPORT_CENTER_URL= SUPPORT_CENTER_TEXT= @@ -33,4 +31,3 @@ TRADEMARK_TEXT= SITE_URL= LOGO_ALT_TEXT= SHOW_LOGO= -SUPPORT_EMAIL= diff --git a/README.rst b/README.rst index e04d55fcac..4a13dfd8e2 100644 --- a/README.rst +++ b/README.rst @@ -184,27 +184,15 @@ Reporting Security Issues ========================= Please do not report security issues in public. Please email security@openedx.org. -======= -*********** -Local Development -*********** - -For local development and testing follow these steps. (for convenience sake consider learning MFE as parent app) - -* Clone frontend-component-footer-mitol into frontend-app-learning directory. -* CD into the frontend-component-footer-mitol and run the following commands:: - - npm i - - npm build -* Verify a `dist/` directory has been created. -* CD back into frontend-app-learning and create a module.config.js file -* Place the following code in the module.config.js:: - - module.exports = { - localModules: [ - { moduleName: '@edx/frontend-component-footer', dir: './frontend-component-footer-mitol' }, - } - -* Restart frontend-app-learning and verify it is using the local version from @edx/frontend-component-footer -* For css changes you might need to rebuild again. +.. |Build Status| image:: https://api.travis-ci.com/edx/frontend-component-footer.svg?branch=master + :target: https://travis-ci.com/edx/frontend-component-footer +.. |Codecov| image:: https://img.shields.io/codecov/c/github/edx/frontend-component-footer + :target: @edx/frontend-component-footer +.. |npm_version| image:: https://img.shields.io/npm/v/@edx/frontend-component-footer.svg + :target: @edx/frontend-component-footer +.. |npm_downloads| image:: https://img.shields.io/npm/dt/@edx/frontend-component-footer.svg + :target: @edx/frontend-component-footer +.. |license| image:: https://img.shields.io/npm/l/@edx/frontend-component-footer.svg + :target: @edx/frontend-component-footer +.. |semantic-release| image:: https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg + :target: https://github.com/semantic-release/semantic-release diff --git a/package.json b/package.json index 468b822d00..ddb9f543b3 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { - "name": "@mitodl/frontend-component-footer-mitol", + "name": "@edx/frontend-component-footer-mitol", "version": "1.0.0-semantically-released", - "description": "Footer component for use when building Open edX frontend applications for MITX", + "description": "Footer component for use when building Open edX frontend applications", "main": "dist/index.js", "publishConfig": { "access": "public" @@ -25,14 +25,14 @@ }, "repository": { "type": "git", - "url": "git+https://github.com/mitodl/frontend-component-footer-mitol" + "url": "git+https://github.com/openedx/frontend-component-footer.git" }, - "author": "MIT", + "author": "edX", "license": "AGPL-3.0", "bugs": { - "url": "https://github.com/mitodl/frontend-component-footer-mitol/issues" + "url": "https://github.com/openedx/frontend-component-footer/issues" }, - "homepage": "https://github.com/mitodl/frontend-component-footer-mitol#readme", + "homepage": "https://github.com/openedx/frontend-component-footer#readme", "devDependencies": { "@edx/brand": "npm:@openedx/brand-openedx@^1.2.2", "@edx/browserslist-config": "^1.1.1", @@ -63,7 +63,6 @@ "peerDependencies": { "@edx/frontend-platform": "^7.0.0", "@openedx/paragon": ">= 21.11.3 < 23.0.0", - "@edx/paragon": "<22.0.0", "prop-types": "^15.5.10", "react": "^16.9.0 || ^17.0.0", "react-dom": "^16.9.0 || ^17.0.0" diff --git a/src/components/Footer.jsx b/src/components/Footer.jsx index 1984ba2799..aa8dfb65f8 100644 --- a/src/components/Footer.jsx +++ b/src/components/Footer.jsx @@ -56,7 +56,7 @@ class SiteFooter extends React.Component { && (