Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect message for locking #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DmytroAlipov
Copy link
Contributor

Description:

Reproduction steps:

  1. Two Staff go to Instructors tab
  2. Open responses and choose ORA
  3. By each staff choose user answer
  4. By first staff click on "Start grading" button
  5. By second staff click on "Start grading" button

Then for the second Staff it will be displayed:
screen_63

The message selection process was incorrect because a 409 was received from the server (as intended).

Now this message is displayed:
screen_64

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 29, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 29, 2024

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-unmaintained. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f433d33) to head (b3879cb).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #326   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          111       111           
  Lines         1082      1082           
  Branches       159       159           
=========================================
  Hits          1082      1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroAlipov
Copy link
Contributor Author

@mphilbrick211 @arbrandes hi 😉 just a friendly ping

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies it took a while, but I have no objections. Approved!

@arbrandes arbrandes enabled auto-merge (rebase) May 16, 2024 15:09
@arbrandes arbrandes disabled auto-merge May 16, 2024 15:10
@arbrandes arbrandes enabled auto-merge (rebase) May 16, 2024 15:10
@arbrandes
Copy link
Contributor

I set this to auto-merge once the branch is rebased.

auto-merge was automatically disabled May 16, 2024 21:05

Head branch was pushed to by a user without write access

@DmytroAlipov DmytroAlipov force-pushed the fix-incorrect-message-for-locking branch from f10b4fc to 6d2aae0 Compare May 16, 2024 21:05
@DmytroAlipov
Copy link
Contributor Author

Hi @arbrandes
I rebased, but the auto-merge didn't happen.

@mphilbrick211
Copy link

Hi @arbrandes I rebased, but the auto-merge didn't happen.

@arbrandes flagging this for you!

@DmytroAlipov DmytroAlipov force-pushed the fix-incorrect-message-for-locking branch from 6d2aae0 to b3879cb Compare September 3, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready to Merge
Development

Successfully merging this pull request may close these issues.

4 participants