-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect message for locking #326
base: master
Are you sure you want to change the base?
fix: incorrect message for locking #326
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 111
Lines 1082 1082
Branches 159 159
=========================================
Hits 1082 1082 ☔ View full report in Codecov by Sentry. |
@mphilbrick211 @arbrandes hi 😉 just a friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies it took a while, but I have no objections. Approved!
I set this to auto-merge once the branch is rebased. |
Head branch was pushed to by a user without write access
f10b4fc
to
6d2aae0
Compare
Hi @arbrandes |
@arbrandes flagging this for you! |
6d2aae0
to
b3879cb
Compare
Description:
Reproduction steps:
Then for the second Staff it will be displayed:
The message selection process was incorrect because a 409 was received from the server (as intended).
Now this message is displayed: