From c4025c3c05ef927684d72bb7594fba1b7700cfcc Mon Sep 17 00:00:00 2001 From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> Date: Tue, 3 Sep 2024 16:43:18 +0500 Subject: [PATCH] test: Add Node 20 to CI matrix (#326) * test: Add Node 20 to CI matrix * fix: updated failing snapshots --- .github/workflows/node-ci.yml | 10 +++--- .../ProgramListPage.test.jsx.snap | 32 +++++++++---------- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml index 69b5eaa7..c2ae932d 100644 --- a/.github/workflows/node-ci.yml +++ b/.github/workflows/node-ci.yml @@ -11,16 +11,18 @@ on: jobs: tests: runs-on: ubuntu-20.04 + strategy: + matrix: + node: [18, 20] + continue-on-error: ${{ matrix.node == 20 }} steps: - name: Checkout uses: actions/checkout@v3 - - name: Setup Nodejs Env - run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV - name: Setup Nodejs - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: ${{ env.NODE_VER }} + node-version: ${{ matrix.node }} - name: Install dependencies run: npm ci diff --git a/src/components/programs-list/tests/__snapshots__/ProgramListPage.test.jsx.snap b/src/components/programs-list/tests/__snapshots__/ProgramListPage.test.jsx.snap index ee9e73b9..fc21a4bb 100644 --- a/src/components/programs-list/tests/__snapshots__/ProgramListPage.test.jsx.snap +++ b/src/components/programs-list/tests/__snapshots__/ProgramListPage.test.jsx.snap @@ -222,7 +222,7 @@ exports[`ProgramListPage correctly renders the loading page 1`] = ` > @@ -251,7 +251,7 @@ exports[`ProgramListPage correctly renders the loading page 1`] = ` > @@ -280,7 +280,7 @@ exports[`ProgramListPage correctly renders the loading page 1`] = ` >