build: Upgrade to Node 20 #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 163 163
Lines 1452 1452
Branches 245 244 -1
=======================================
Hits 1390 1390
Misses 58 58
Partials 4 4 ☔ View full report in Codecov by Sentry. |
jsnwesson
added
waiting for eng review
|
@BilalQamar95 Annnnd another conflict on this one too. |
|
@justinhynes I have resolved conflicts & updated the PR |
|
PR will be updated and ready for review once the prerequisite PR for first step of the node v20 upgrade process is merged. |
BilalQamar95
force-pushed
the
bilalqamar95/node-v20-upgrade
branch
from
f0fc692
to
0f7908d
Compare
Closed
MaxFrank13
approved these changes
Aug 23, 2024
MaxFrank13
approved these changes
Aug 23, 2024
MaxFrank13
removed
waiting for eng review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
package-lock.jsonwith nodev20and NPM10..nvmrctov20lockfileversion check workflowSecond step in the Node 20 upgrade process, See the tracking issue for futher information.