Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #161

Merged
merged 11 commits into from
Aug 28, 2023
Merged

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jun 13, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with react-test-renderer, @fortawesome/react-fontawesome & @testing-library/react to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated edx package @edx/paragon

@Mashal-m Mashal-m changed the title Mashal m/react upgrade to v17 feat: update react & react-dom to v17 Jun 13, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (64563d5) 96.45% compared to head (01aafe2) 96.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         195      195           
  Lines        1834     1834           
  Branches      321      321           
=======================================
  Hits         1769     1769           
  Misses         60       60           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review July 25, 2023 09:36
@Mashal-m Mashal-m force-pushed the mashal-m/react-upgrade-to-v17 branch from 69cffcb to f897cea Compare August 23, 2023 07:54
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mattcarter mattcarter merged commit 199d6e7 into master Aug 28, 2023
5 checks passed
@mattcarter mattcarter deleted the mashal-m/react-upgrade-to-v17 branch August 28, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants