Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove Python 3.8 references #537

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

DawoudSheraz
Copy link
Contributor

Since Python 3.8 has reached the end of life, keeping 3.8 related references in edx-val is not needed.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (9846e6c) to head (902ed80).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
+ Coverage   94.48%   94.52%   +0.04%     
==========================================
  Files          31       31              
  Lines        3099     3106       +7     
  Branches      173      120      -53     
==========================================
+ Hits         2928     2936       +8     
  Misses        152      152              
+ Partials       19       18       -1     
Flag Coverage Δ
unittests 94.52% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to release a new version as well since the support of Python 3.8 is being dropped.

@DawoudSheraz
Copy link
Contributor Author

It would be better to release a new version as well since the support of Python 3.8 is being dropped.

I will do it in a followup PR.

@DawoudSheraz DawoudSheraz merged commit 12a39d3 into master Nov 1, 2024
8 checks passed
@DawoudSheraz DawoudSheraz deleted the dsheraz/remove-py38-ci branch November 1, 2024 12:19
@DawoudSheraz
Copy link
Contributor Author

Created #538 for version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants