feat: check course start date for courseware search #35740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijuma
approved these changes
Oct 30, 2024
schenedx
reviewed
Oct 30, 2024
| start_date = CourseOverview.get_from_id(course_key).start | ||
|
|
||
| # only include courses that have a start date later than the setting-defined inclusion date | ||
| if inclusion_date: |
There was a problem hiding this comment.
Should we set enabled to False without the inclusion_date value?
There was a problem hiding this comment.
If there's no inclusion date, we should just rely on the default behavior in this view, which is why this is separated into a separate conditional.
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current courseware search design does not account for whether or not the course being searched has been properly indexed. In order to only enable courseware search for courses that have been indexed, a new feature setting
COURSEWARE_SEARCH_INCLUSION_DATEshould be included and used to denote a date from which all courses have been indexed if their start date is greater than the inclusion date.COSMO-309