-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping Sass support from builtin html block #35719
Conversation
0748893
to
9e7aeed
Compare
7721307
to
1341a47
Compare
9e7aeed
to
e482913
Compare
1341a47
to
cee0957
Compare
e482913
to
f4b7757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
84662de
to
3151048
Compare
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
3151048
to
6ad6ec3
Compare
Sandbox deployment successful 🚀 |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Dropping Sass support from builtin html block
Parent story: #35300
Tasks:
Convert Sass variable into css variables
Compile the css file of the block following given steps.
xmodule/static/css-builtin-blocks
.Replace add_sass_to_fragment to add_css_to_fragment in blocks
.py
fileRemove all .scss files linked to the block under xmodule/assets.
Testing Notes:
npm run build
to run webpack and compile sass files../manage.py lms collectstatic
in lms shell to re-collect static files../manage.py cms collectstatic
in cms shell to re-collect static files.