Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update catalog-info file for release data #35691

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Update catalog-info file for release data #35691

merged 2 commits into from
Oct 24, 2024

Conversation

salman2013
Copy link
Contributor

@salman2013 salman2013 commented Oct 22, 2024 •
edited
Loading

Description:
Update catalog-info.yaml file for release data, as the BTR script has been updated to read the catalog-info.yaml file if it has release data, we are updating the catalog-info file as per Deprecate openedx.yaml

@salman2013 salman2013 added the hacktoberfest-accepted Issue accepted for hacktoberfest participants label Oct 22, 2024
@salman2013 salman2013 self-assigned this Oct 22, 2024
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U labels Oct 22, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @salman2013!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

1 similar comment
@openedx-webhooks
Copy link

Thanks for the pull request, @salman2013!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@salman2013 salman2013 changed the title Update catalog.yaml file for release data Update catalog-info file for release data Oct 22, 2024
feanil
feanil requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should delete the openedx.yaml in the same PR.

@salman2013
Copy link
Contributor Author

@feanil I have also deleted openedx.yaml file in this PR.

feanil
feanil reviewed Oct 23, 2024
View reviewed changes
catalog-info.yaml
@@ -10,6 +10,8 @@ metadata:
- url: "https://docs.openedx.org"
title: "Documentation"
icon: "Web"
annotations:
openedx.org/release: "2u/release"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openedx.org/release: "2u/release"
openedx.org/release: "master"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think given the issues we saw today and the fact that we have a month of testing after the release is cut, it's less important that we cut off of what 2U has released, if they do run into issues, we will hopefully backport the fixes at that point.

@salman2013 @farhaanbukhsh as release manager I think you have the final say on this, what do you think?

@feanil
Copy link
Contributor

feanil commented Oct 23, 2024

@salman2013 this looks good to me now, but it's a good time to update the release branch if we want to do that so I'll give the current/previous release manager a moment to comment on that before we merge with/without my suggestion. I'll approve once that's settled.

@cmltaWt0
Copy link
Contributor

@salman2013 this looks good to me now, but it's a good time to update the release branch if we want to do that so I'll give the current/previous release manager a moment to comment on that before we merge with/without my suggestion. I'll approve once that's settled.

Regarding the release process it's totally OK to switch to the master branch.

@farhaanbukhsh
Copy link
Member

@feanil with all the context that I could gather from yesterday's call (thanks to @cmltaWt0 ) I think it's fine to base the release on master :)

arbrandes
arbrandes approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @cmltaWt0 and BTR.

@arbrandes arbrandes merged commit a19993c into openedx:master Oct 24, 2024
49 checks passed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil requested changes

@arbrandes arbrandes arbrandes approved these changes

@farhan farhan Awaiting requested review from farhan

@irtazaakram irtazaakram Awaiting requested review from irtazaakram

Assignees

@salman2013 salman2013

Labels
hacktoberfest-accepted Issue accepted for hacktoberfest participants open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@salman2013 @openedx-webhooks @feanil @cmltaWt0 @farhaanbukhsh @edx-pipeline-bot @arbrandes