Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bok-choy reference #34216

Merged
merged 3 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,6 @@ def _save_xblock(
publish = "make_public"

# Make public after updating the xblock, in case the caller asked for both an update and a publish.
# Used by Bok Choy tests and by republishing of staff locks.
if publish == "make_public":
modulestore().publish(xblock.location, user.id)

Expand Down
5 changes: 2 additions & 3 deletions lms/envs/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,8 @@
# .. toggle_implementation: DjangoSetting
# .. toggle_default: False
# .. toggle_description: Set to True to perform acceptance and load test. Auto auth view is responsible for load
# testing and is controlled by this feature flag. Auto-auth causes issues in Bok Choy tests because it resets the
# requesting user. Session verification (of CacheBackedAuthenticationMiddleware) is a security feature, but it
# can be turned off by enabling this feature flag.
# testing and is controlled by this feature flag. Session verification (of CacheBackedAuthenticationMiddleware)
# is a security feature, but it can be turned off by enabling this feature flag.
# .. toggle_use_cases: open_edx
# .. toggle_creation_date: 2013-07-25
# .. toggle_warning: If this has been set to True then the account activation email will be skipped.
Expand Down
3 changes: 1 addition & 2 deletions openedx/core/djangoapps/cache_toolbox/middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ def _verify_session_auth(self, request):
"""
Ensure that the user's session hash hasn't changed.
"""
# Auto-auth causes issues in Bok Choy tests because it resets
# the requesting user. Since session verification is a
# Since session verification is a
# security feature, we can turn it off when auto-auth is
# enabled since auto-auth is highly insecure and only for
# tests.
Expand Down
2 changes: 0 additions & 2 deletions openedx/tests/xblock_integration/xblock_testcase.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ class XBlockEventTestMixin:
Good things to look at as developing the code:
* Gabe's library for parsing events. This is nice.
* Bok choy has a nice Mongo search for events in the cohorts test
case. It is a little slow for the general case.
* This is originally based on a cleanup of the EventTestMixin. We
could work to converge those in some sensible way.
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ window.LibraryContentAuthorView = function(runtime, element) {
// But it is still inside this xblock's wrapper element, which we can easily find:
var $wrapper = $element.parents('*[data-locator="' + usage_id + '"]');

// We can't bind to the button itself because in the bok choy test environment,
// it may not yet exist at this point in time... not sure why.
$wrapper.on('click', '.library-update-btn', function(e) {
e.preventDefault();
// Update the XBlock with the latest matching content from the library:
Expand Down
1 change: 0 additions & 1 deletion xmodule/library_content_block.py
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,6 @@ def get_user_id(self):
"""
user_service = self.runtime.service(self, 'user')
if user_service:
# May be None when creating bok choy test fixtures
user_id = user_service.get_current_user().opt_attrs.get('edx-platform.user_id', None)
else:
user_id = None
Expand Down
Loading