fix: fix request.is_ajax() deprecation warning #33055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
reviewed
Aug 18, 2023
| @@ -288,7 +288,7 @@ def forum_form_discussion(request, course_key): | |||
| """ | |||
| course = get_course_with_access(request.user, 'load', course_key, check_if_enrolled=True) | |||
| request.user.is_community_ta = utils.is_user_community_ta(request.user, course.id) | |||
| if request.is_ajax(): | |||
| if request.headers.get('x-requested-with') == 'XMLHttpRequest': | |||
There was a problem hiding this comment.
5dcb8812157' and requested host was 'awais786.sandbox.edx.org'; CORS_ORIGIN_ALLOW_ALL=False
2023-08-18 14:03:16,660 INFO 187478 [edx.discussions] [user 20] [ip 44.230.155.124] views.py:356 - XMLHttpRequest
2023-08-18 14:03:16,660 INFO 187478 [edx.discussions] [user 20] [ip 44.230.155.124] views.py:357 - -------------------------------
2023-08-18 14:03:16,660 INFO 187478 [edx.discussions] [user 20] [ip 44.230.155.124] views.py:359 - vvvvvvvvvvvvvvv
verified logs appearing after condition got true.
awais786
approved these changes
Aug 18, 2023
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
mehedikhan72
pushed a commit
to mehedikhan72/edx-platform
that referenced
this pull request
Aug 24, 2023
* fix: fix request.is_ajax() deprecation warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description