fix: fix django.utils.translations warnings #33040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
force-pushed
the
update-deprecated-gettext-methods
branch
from
1418a4e
to
2ad1f38
Compare
awais786
approved these changes
Aug 17, 2023
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
mehedikhan72
pushed a commit
to mehedikhan72/edx-platform
that referenced
this pull request
Aug 24, 2023
* fix: fix ugetext and ngettext deprecation warnings * fix: fix deprecation warnings from html templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix following deprecation warnings and fixes issue [Django 4.2 Support]: django.utils.translation.ungettext() is deprecated #33037
django.utils.translation.ugettext() is deprecated in favor of django.utils.translation.gettext()django.utils.translation.ungettext() is deprecated in favor of django.utils.translation.ngettext()Some instances of these methods are still remaining but they are not producing any deprecation warnings and we need to update both
i18nandopenedx/Xblockrepos first before refactoring those instances to avoid test failures. So these will be refactored in a later PR if needed.