Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: discussions.pages_and_resources_mfe waffle flag #35254

Open
ormsbee opened this issue Aug 8, 2024 · 3 comments
Open

[DEPR]: discussions.pages_and_resources_mfe waffle flag #35254

ormsbee opened this issue Aug 8, 2024 · 3 comments
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@ormsbee
Copy link
Contributor

ormsbee commented Aug 8, 2024

Proposal Date

2024-08-08

Target Ticket Acceptance Date

2024-08-22

Earliest Open edX Named Release Without This Functionality

Sumac

Rationale

The target removal date was 2021-12-31, and this flag no longer really works in the sense that if you're in the MFE experience for Studio, you still get the new Pages and Resources UI regardless of the value of this flag.

Removal

CourseWaffleFlag "to enable new Pages and Resources experience for course".

# .. toggle_name: discussions.pages_and_resources_mfe
# .. toggle_implementation: CourseWaffleFlag
# .. toggle_default: False
# .. toggle_description: Waffle flag to enable new Pages and Resources experience for course.
# .. toggle_use_cases: temporary, open_edx
# .. toggle_creation_date: 2021-05-24
# .. toggle_target_removal_date: 2021-12-31
# .. toggle_warning: When the flag is ON, the new experience for Pages and Resources will be enabled.
# .. toggle_tickets: TNL-7791
ENABLE_PAGES_AND_RESOURCES_MICROFRONTEND = CourseWaffleFlag(
f"{WAFFLE_FLAG_NAMESPACE}.pages_and_resources_mfe", __name__
)

Replacement

No replacement–the MFE will always be enabled.

Deprecation

No response

Migration

No response

Additional Info

No response

Task List

No response

@ormsbee ormsbee self-assigned this Aug 8, 2024
@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Aug 8, 2024
@pdpinch
Copy link
Contributor

pdpinch commented Sep 6, 2024

We just stumbled onto a bug where the workaround was to temporarily turn off this waffle flag. I'd appreciate keeping the flag available until the bug is fixed or there is another, well-documented workaround.

I'll update this comment with a link to the bug once I've opened an issue.

@feanil
Copy link
Contributor

feanil commented Sep 19, 2024

@pdpinch did you file that bug somewhere? can you link it here?

@pdpinch
Copy link
Contributor

pdpinch commented Sep 19, 2024

Sorry about not getting back to this.

Here's the issue: #35509

It's very similar to another one for the discussion tab, which has a PR to fix it: #35431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Proposed
Development

No branches or pull requests

3 participants