Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing pact from requirements #32798

Open
kdmccormick opened this issue Jul 20, 2023 · 0 comments
Open

Consider removing pact from requirements #32798

kdmccormick opened this issue Jul 20, 2023 · 0 comments
Labels
discovery Pre-work to determine if an idea is feasible

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Jul 20, 2023

pact is currently the platform's single largest dev depenedency, taking ~30s to install into the dev image:

$ tutor dev run lms bash
app@04531af885b0:~/edx-platform$ cd /openedx/venv/lib/python3.8/site-packages
app@04531af885b0:~/venv/lib/python3.8/site-packages$ du -hs * | sort -h -r | head -n 10
145M	pact
101M	scipy
82M	snowflake
52M	sympy
48M	openassessment
45M	_sass.cpython-38-x86_64-linux-gnu.so
44M	django
35M	numpy.libs
34M	scipy.libs
34M	botocore

pact is a testing dependency of the platform, added by this PR: #28289

I believe only a handful of tests use pact:

~/openedx/edx-platform 🍀 find . -wholename */pacts/*
./common/test/pacts/__init__.py
./common/test/pacts/middleware.py
./openedx/core/djangoapps/courseware_api/tests/pacts/views.py
./openedx/core/djangoapps/courseware_api/tests/pacts/__init__.py
./openedx/core/djangoapps/courseware_api/tests/pacts/api-courseware-contract.json
./openedx/core/djangoapps/courseware_api/tests/pacts/verify_pact.py
./lms/djangoapps/courseware/tests/pacts/views.py
./lms/djangoapps/courseware/tests/pacts/__init__.py
./lms/djangoapps/courseware/tests/pacts/verify_pact.py
./lms/djangoapps/courseware/tests/pacts/course-xblock-handler-contract.json
./lms/djangoapps/course_api/blocks/tests/pacts/views.py
./lms/djangoapps/course_api/blocks/tests/pacts/__init__.py
./lms/djangoapps/course_api/blocks/tests/pacts/api-block-contract.json
./lms/djangoapps/course_api/blocks/tests/pacts/verify_pact.py

Questions

  • What is the value of Pact, and it is worth 145M and extra build time for all devs?
  • The PR, from 2021, refers to a "contact testing pilot". Is this still going?
  • Are there plans to add more Pact tests?
  • How hard would it be to migrate those test cases off of Pact?
@kdmccormick kdmccormick changed the title Consider removing pact-python Consider removing pact from requirements Jul 20, 2023
@kdmccormick kdmccormick added the discovery Pre-work to determine if an idea is feasible label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Pre-work to determine if an idea is feasible
Projects
No open projects
Status: Refined
Development

No branches or pull requests

1 participant