Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bok-choy usage #2122

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

salman2013
Copy link
Contributor

Description

As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.

Ticket: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=45415827

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22f232b) 95.01% compared to head (ab1d6ac) 95.01%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2122   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         191      191           
  Lines       20537    20537           
  Branches     1859     1859           
=======================================
  Hits        19514    19514           
  Misses        767      767           
  Partials      256      256           
Flag Coverage Δ
unittests 95.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems good to me. @openedx/content-aurora when should we expect a review of this by?

@feanil
Copy link
Contributor

feanil commented Nov 27, 2023

@salman2013 should this still be in Draft?

@salman2013 salman2013 marked this pull request as ready for review November 28, 2023 06:03
@salman2013 salman2013 requested a review from a team as a code owner November 28, 2023 06:03
@salman2013
Copy link
Contributor Author

@feanil its ready for review.

@feanil feanil added the open-source-contribution PR author is not from Axim or 2U label Dec 7, 2023
@feanil feanil mentioned this pull request Dec 7, 2023
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Dec 7, 2023
@itsjeyd
Copy link

itsjeyd commented Dec 14, 2023

Hey @mattcarter, just a friendly reminder that this PR is ready for @openedx/2u-aurora to review.

@feanil feanil merged commit 01159ca into openedx:master Dec 19, 2023
8 checks passed
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants