Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bok-choy references #59

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

salman2013
Copy link
Contributor

@salman2013 salman2013 commented Feb 12, 2024

Description:
Remove bok-choy references.

Ticket: openedx/public-engineering#13

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (9f8ef0c) to head (18b259a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files           5        5           
  Lines         224      224           
=======================================
  Hits          207      207           
  Misses         17       17           
Flag Coverage Δ
unittests 92.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're meant to use this script to generate icons for the xblock, is that not needed especially the raw file? I just want to confirm that you were able to spin up the xblock and everything worked as expected?

@kdmccormick kdmccormick removed their assignment Feb 14, 2024
@salman2013
Copy link
Contributor Author

@feanil Yes everything working as expected.

@feanil feanil merged commit 65e32f3 into openedx:master Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants