Fixes for LVS export and import #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrudaya21
approved these changes
Feb 19, 2024
tiagolobocastro
approved these changes
Feb 19, 2024
Yes, I think we should. |
dsavitskiy
force-pushed
the
lvol_fixes
branch
2 times, most recently
from
b34188b
to
af86fa0
Compare
With large number of volumes and/or snapshots, a blobstore may run out of "request set" objects that are used to perform metadata I/O. The "request sets" are allocated from per-channel object pools, which are limited by 512 items by default. This effectively limits number of simultaneous metadata I/O requests. This commit enables a dynamic growth of per-channel "request set" pools. Signed-off-by: Dmitry Savitskiy <[email protected]>
When importing an LVS, logical volumes are iterated and opened in a loop. This can cause I/O requests to accumulate, and lead out-of-resource condition. This fix iterates and open LVOLs asynchronously. Signed-off-by: Dmitry Savitskiy <[email protected]>
dsavitskiy
force-pushed
the
lvol_fixes
branch
from
af86fa0
to
5f386c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.