Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshot): reset num_used_clusters_cache when snapshot created from thin provisioned lvol #30

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

hrudaya21
Copy link

No description provided.

@mtzaurus
Copy link

Do we need to make this function part of public SPDK API ? Can't it just be part of internal logic when creating lvol snapshot ?

@hrudaya21
Copy link
Author

Do we need to make this function part of public SPDK API ? Can't it just be part of internal logic when creating lvol snapshot ?

Not needed for now. I will remove it.

lib/lvol/lvol.c Outdated Show resolved Hide resolved
lib/blob/blobstore.c Show resolved Hide resolved
@hrudaya21
Copy link
Author

Do we need to make this function part of public SPDK API ? Can't it just be part of internal logic when creating lvol snapshot ?

Not needed for now. I will remove it.

It seems, to operate on blob, the operations should be in blob lib and should be acccess through interface in lvol lib.
In that case, We need to have interface from blob for this.

@hrudaya21 hrudaya21 marked this pull request as ready for review July 12, 2023 15:10
include/spdk/blob.h Outdated Show resolved Hide resolved
lib/lvol/lvol.c Outdated Show resolved Hide resolved
lib/lvol/lvol.c Outdated Show resolved Hide resolved
@mtzaurus
Copy link

I'd also recommend to perform a full BDD run in Mayastor against this commit before merging it, to make sure nothing unexpected is introduced by these SPDK changes.

@hrudaya21 hrudaya21 requested a review from mtzaurus July 17, 2023 10:28
@hrudaya21
Copy link
Author

I'd also recommend to perform a full BDD run in Mayastor against this commit before merging it, to make sure nothing unexpected is introduced by these SPDK changes.

Full BDD executed and no issues observed with this commit.

@hrudaya21 hrudaya21 merged commit 367b8d3 into openebs:v23.01.x-mayastor Jul 18, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants