Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle removal of etcd.initialClusterState during helm upgrade in upgrade-job #1735

Open
niladrih opened this issue Sep 12, 2024 · 0 comments
Assignees
Labels
Upgrade Upgrade infra or dependency

Comments

@niladrih
Copy link
Member

niladrih commented Sep 12, 2024

Ref: openebs/mayastor-extensions#536

The upgrade-job, as of 2.7.0 reuses all of the existing helm values from the source chart. The removal of the parameter from the values.yaml would mean that during upgrade that value has to be forcibly removed when moving to 2.7.0+ versions. This needs to be handled somehow.

If there is no new design changes to upgrade, a new entry to the helm::values.rs module is required which explicitly removes the value from the values set. This might also be required even if helm's --reset-then-reuse-values flag is used, as previous upgrade-jobs would have used the -f values.yaml option during upgrade and would have explicitly set ALL of the source chart's values (and they would be now visible on helm get values output).

@niladrih niladrih self-assigned this Sep 12, 2024
@niladrih niladrih added the Upgrade Upgrade infra or dependency label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upgrade Upgrade infra or dependency
Projects
None yet
Development

No branches or pull requests

1 participant