Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the CLI model registry client once MR supports proper REST status codes #244

Open
devguyio opened this issue Apr 9, 2024 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@devguyio
Copy link
Contributor

devguyio commented Apr 9, 2024

Description

The Model Registry currently does not follow the REST standard status codes (e.g., 404 for non-existing resources). Instead, it returns 500, and the error details are in the response. Some custom error checking was used in the cli modelregistry client.

However, model registry is planning to change that and support standard REST status codes, see opendatahub-io/model-registry-bf4-kf#305 .

Once that's implemented, the modelregistry client will need to be refactored to check those status codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Untriaged
Development

No branches or pull requests

1 participant