Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: For bike-rentals, more than the aws-bucket-name needs to be changed to test S3 #174

Open
adelton opened this issue Nov 16, 2023 · 0 comments
Labels
kind/bug Something isn't working

Comments

@adelton
Copy link
Contributor

adelton commented Nov 16, 2023

Details

Describe the bug

The #112 changed the default parameters in build-container-image-pipelinerun-bike-rentals.yaml to fetch from git but the section https://github.com/opendatahub-io/ai-edge/blob/main/pipelines/README.md#for-s3-fetch still says

Update the aws-bucket-name parameter value from its default rhoai-edge-models in build-container-image-pipelinerun-bike-rentals.yaml and/or build-container-image-pipelinerun-tensorflow-housing.yaml to match your S3 bucket name.

To Reproduce

Follow the https://github.com/opendatahub-io/ai-edge/blob/main/pipelines/README.md and try to fetch from S3 by only changing the aws-bucket-name.

The PipelineRun will still show that git-clone-model-repo was run.

Expected behavior

The documentation should be clear about what the repository demonstrates out of box, with minimal changes, and how to achieve the alternate behaviour.

Screenshots (if applicable)

@adelton adelton added the kind/bug Something isn't working label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Untriaged
Development

No branches or pull requests

1 participant