Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin image versions #122

Open
piotrpdev opened this issue Oct 4, 2023 · 3 comments
Open

Pin image versions #122

piotrpdev opened this issue Oct 4, 2023 · 3 comments
Labels
good first issue Good for newcomers kind/enhancement New feature or request priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt)

Comments

@piotrpdev
Copy link
Member

piotrpdev commented Oct 4, 2023 •
edited
Loading

Description

These are unpinned:

ai-edge/pipelines/containerfiles/Containerfile.ab-jq

Line 1 in a1fbed4

FROM registry.access.redhat.com/ubi9/ubi-minimal

ai-edge/pipelines/tekton/test-mlflow-image-pipeline/test-mlflow-rest-svc-task.yaml

Line 16 in 62bb5f6

image: registry.access.redhat.com/ubi9/ubi

ai-edge/pipelines/tekton/azureml-container-pipeline/check-model-and-containerfile-exists.yaml

Line 17 in a1fbed4

image: registry.access.redhat.com/ubi9/ubi-micro

A/C

  • Pin the version of the images above.
  • Make sure anything that uses the images still works.
@piotrpdev piotrpdev added good first issue Good for newcomers kind/enhancement New feature or request priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) labels Oct 4, 2023
@adelton
Copy link
Contributor

adelton commented Oct 6, 2023 •
edited
Loading

What would pinning (I assume you mean to use a specific tag different than latest) these images actually bring us?

I can see only the downside of forcing images that sooner or later will have CVEs reported for them.

@piotrpdev
Copy link
Member Author

piotrpdev commented Oct 6, 2023 •
edited
Loading

What would pinning (I assume you mean to use a specific tag different than latest) these images actually bring us?

I can see only the downside of forcing images that sooner or later will have CVEs reported to the system.

Good for reproducibility in the future especially considering #134 ¯\(ツ)/¯

@adelton
Copy link
Contributor

adelton commented Oct 6, 2023

The #134 strives to support exactly using :latest, and still know that nothing broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement New feature or request priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adelton @piotrpdev