Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed URL can be written to STIX. #1135

Open
delliott90 opened this issue Sep 29, 2022 · 2 comments
Open

Malformed URL can be written to STIX. #1135

delliott90 opened this issue Sep 29, 2022 · 2 comments

Comments

@delliott90
Copy link
Collaborator

Describe the bug
According to the STIX spec, URLs must confirm to RFC3986. STIX-shifter can currently write data to the url.value property that doesn't conform to this standard. For example if the URL is missing http:// or https://

Expected behavior
Validation should run on the data mapped to the url.value property before being written to STIX. If the data fails validation it should be omitted from the results.

@pcoccoli
Copy link
Contributor

pcoccoli commented Oct 4, 2022

If the scheme is missing, would it make sense to just add http:// in front of the value?

@delliott90
Copy link
Collaborator Author

The problem is we wouldn't know if we should add http:// or https://

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants