fix post stop hook not always called successfully #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first time post stop hook called with a failure(maybe because some resources is not ready to be recycled), the second retry of `runc delete` will return directly because the container root directoy is already removed. so that the post stop hook is not called. Signed-off-by: Abel Feng <[email protected]>
|
Thanks! This change of behavior, judging from the runtime-spec PR, requires a change of behavior at the runtime-spec first. I'm marking as draft for now, let me know if I'm missing something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first time post stop hook called with a failure(maybe because some resources is not ready to be recycled), the second retry of
runc deletewill return directly because the container root directoy is already removed. so that the post stop hook is not called.I think we may have to do container root dir removal after post stop hook executed. I think it is also more consistant with the sematics of "Poststop", because otherwise it should be "PostDelete".
fix #4363