Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid repeated os.SetEnv calls in container init. #1983

Closed
wants to merge 1 commit into from
Closed

Avoid repeated os.SetEnv calls in container init. #1983

wants to merge 1 commit into from

Commits on Feb 13, 2019

  1. Avoid repeated os.SetEnv calls in container init. 

    For containers with a large number of configured environment variables
(>5000), os.SetEnv can make container creation take a much longer time
than in normal circumstances. This is due to os.SetEnv locking and
unlocking a mutex on every environment variable added.

By removing the os.SetEnv calls during
container creation, and instead controlling the list of environment
variables manually, this overhead can be removed.

Signed-off-by: Brandon Mabey <[email protected]>
    @brandon-mabey
    brandon-mabey committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    61c31c2 View commit details
    Browse the repository at this point in the history