Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add multicast counters to ip interface, remove physical counters from subinterface" #933

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

dplore
Copy link
Member

@dplore dplore commented Jul 28, 2023

Reverts #905

#905 unintentionally removed counters from IP subinterfaces. A new PR will be introduced to fix this.

FYI, this breaking change was detected by the following featureprofiles CI check. We will look into exposing public model breaking changes via checks like this.

@OpenConfigBot
Copy link

No major YANG version changes in commit f765bb2

@OpenConfigBot
Copy link

Compatibility Report for commit f765bb2:
pyangbind@b1762a3

@robshakir
Copy link
Contributor

revert lgtm.

@dplore dplore marked this pull request as ready for review July 28, 2023 21:28
@dplore dplore requested a review from a team as a code owner July 28, 2023 21:28
@dplore
Copy link
Member Author

dplore commented Jul 28, 2023

CI fail check is expected for version numbering because this is reverting to older version for
openconfig-if-ip.yang and openconfig-interfaces.yang

@dplore dplore merged commit ce227e7 into master Jul 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants