Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bias voltage thresholds #907

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Conversation

jnelson-sj
Copy link
Contributor

Change Scope

  • This change adds support for getting transceiver optical monitoring thresholds for power supply voltage and laser bias current. Each of these thresholds has a high value and a low value. The transceiver is considered to be in an alarmed state if the relevant parameter is above the high threshold or below the low threshold.
  • This change is backwards compatible.

Platform Implementations

Tree

Changes are in bold

module: openconfig-platform-transceiver

  augment /oc-platform:components/oc-platform:component:
    +--rw transceiver
       +--rw config
       +--ro state
       +--rw physical-channels
       +--rw thresholds
          +--ro threshold* [severity]
             +--ro severity    -> ../state/severity
             +--ro state
                +--ro severity?                   identityref
                +--ro laser-temperature-upper?    decimal64
                +--ro laser-temperature-lower?    decimal64
                +--ro output-power-upper?         decimal64
                +--ro output-power-lower?         decimal64
                +--ro input-power-upper?          decimal64
                +--ro input-power-lower?          decimal64
                +--ro laser-bias-current-upper?   decimal64
                +--ro laser-bias-current-lower?   decimal64
                +--ro supply-voltage-upper?       decimal64
                +--ro supply-voltage-lower?       decimal64
  

@jnelson-sj jnelson-sj requested a review from a team as a code owner July 10, 2023 18:48
@OpenConfigBot
Copy link

OpenConfigBot commented Jul 10, 2023

Major YANG version changes in commit 6c205fe:

@dplore
Copy link
Member

dplore commented Jul 14, 2023

Will discuss in OC Operators meeting July 18, 2023

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reviewed today. @oscargdd asked to clarify which attribute should be used for the threshold comparison? The descriptions for the container or leaf should specify if mix/max/avg/instant should be used. I expect it is instant, but it is good to explicitly define this in the description for the container (as I think all the leaves would operate on the instant value).

@dplore
Copy link
Member

dplore commented Jul 18, 2023

Additional implementation references:

@jnelson-sj
Copy link
Contributor Author

Added comment in the threshold container: "Each threshold is compared to the instant value of the measured parameter corresponding to the threshold";

@dplore dplore merged commit 94aeb47 into openconfig:master Jul 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants