Clarify management and cpu interface type descriptions #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No major YANG version changes in commit 780c1d4 |
LimeHat
suggested changes
Jul 26, 2024
|
Setting last call to Nov 5, 2024 |
s19nal
reviewed
Oct 22, 2024
| a system. This is sometimes also called an internal control plane | ||
| interface. On systems that represent the CPU interface(s) | ||
| as Ethernet this leaf should be used to distinguish these internal | ||
| interface from dataplane and management interfaces."; |
Comment on lines
+731
to
+732
| This interface is not connected to an INTEGRATED_CIRCUIT and | ||
| therefore not typically used for dataplane traffic. It may be |
There was a problem hiding this comment.
this is the only part of the description that seems slightly off to me. I'm not sure I can come up with a better description, but why the use of capitalised 'INTEGRATED_CIRCUIT'? I think I'm likely missing the significance of this term - it makes sense that a dedicated management only interface is not designed to make use of the devices dataplane, but what is the relevance of not connecting to an IC? Surely there could be a separate IC specifically designed to handle management plane traffic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Scope