Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont omit output when script fails #98

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Feb 3, 2024

Previously when the whole script fails the individual models' results were being discarded. This makes debugging more difficult. Now append them to the script stderr output.

See results from openconfig/public#1043

e.g. https://gist.github.com/OpenConfigBot/2b079ba55f45e202440eed488d274d1b, https://gist.github.com/OpenConfigBot/b0961781139bc51fc2d25c15942f2eb2

@wenovus wenovus requested a review from dplore February 3, 2024 00:45
Copy link

github-actions bot commented Feb 3, 2024

Pull Request Test Coverage Report for Build 7763273478

  • -3 of 27 (88.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 55.307%

Changes Missing Coverage Covered Lines Changed/Added Lines %
post_results/main.go 24 27 88.89%
Totals Coverage Status
Change from base Build 7051208360: 0.2%
Covered Lines: 964
Relevant Lines: 1743

💛 - Coveralls

@wenovus wenovus merged commit c1701f1 into master Feb 5, 2024
7 checks passed
@wenovus wenovus deleted the dont-omit-output-when-script-fails branch February 5, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants