Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue migration to 2.7 #108

Open
kirankumarb07 opened this issue Aug 30, 2023 · 9 comments
Open

Vue migration to 2.7 #108

kirankumarb07 opened this issue Aug 30, 2023 · 9 comments

Comments

@kirankumarb07
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Vue 2 goes end of life at the end of 2023 hence as first milestone deliverable we are going to migrate from existing Vue version to 2.7.

Please refer following Meeting minutes.

https://github.com/openbmc/openbmc/wiki/GUI-Design-work-group#date-083023

Describe the solution you'd like
As Vue2.7 has been used some of Vue3 version functions. Please refer following link for more details.

https://v2.vuejs.org/v2/guide/migration-vue-2-7

Describe alternatives you've considered
Instead of going Vue3 version directly its get familiar with community members, we can consider to go with Vue2.7 version as first milestone after that we can consider to move Vue3 version migration.

Additional context

https://v2.vuejs.org/lts/

https://v3-migration.vuejs.org/

@kirankumarb07
Copy link
Contributor Author

@csiegpman
Copy link

How to run Web UI code using VS Code on a Windows system? I want to quickly view the UI and see the changes made.

@kirankumarb07
Copy link
Contributor Author

How to run Web UI code using VS Code on a Windows system? I want to quickly view the UI and see the changes made.

Hi @csiegpman ,

This question may not related to this task. This is generic question so can you ask same in Discord##WebUI channel.

@sivaprabug
Copy link
Contributor

Everyone we are facing some conflict while updating Vue 2.7 with the composition API.

We need to update the routers, mixins, and stores after integration of the composition API and it also observed that some of the libs also sync with the Composition API. We tried implementing Composition API in the Login page and found that validation, and toast messages are not working as expected.

We saw the following console error after integrating PR#66867

image

Have you faced the same issues as above? please confirm.

Note:

While upgrading to VUE3 below libraries are compatible.

We need to consider the above things also.

@Renuka9527 also commented in PR#66867 few limitations in Vue 2.7

@kirankumarb07
Copy link
Contributor Author

@Renuka9527
Copy link

@sivaprabug @kirankumarb07 yes we are facing the same error

@kirankumarb07
Copy link
Contributor Author

@sivaprabug @kirankumarb07 yes we are facing the same error

@Renuka9527 Thanks for confirmation. So is your team working to resolve those console errors ? is your team also exploring to integrate composition API in any one of pages ? Can you please confirm.

If we are facing some many issues while integrating composition API, then we may need to think of plan how we can proceed further on this? As more efforts may needed to implement composition API with existing framework. Please provide feedback on this.

@gtmills @sivaprabug

@Renuka9527
Copy link

@kirankumarb07
We tried to integrate composition API and resolve those console errors, but couldn't find any solution yet.
Looking at these challenges, we may need to re-visit the plan.

@gtmills @Nikhil-Ashoka @sivaprabug

@gtmills
Copy link
Member

gtmills commented Nov 1, 2023

The discussion in the Nov 1st 2023 meeting was let's work on moving to Vue 3 directly and not move to 2.7 first #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants