map of properties constructor should not emit PropertiesChanged signals

[bradbishop]

I suspect the signals in the ObjectManager and Properties interfaces are/were conflated by someone at some point. It probably does make sense to emit an InterfacesAdded signal here by default. It probably does not ever make sense to emit PropertiesChanged signals here (which is what happens by default when this constructor is used):

Definitions::Definitions(bus::bus& bus, const char* path,
                           const std::map<std::string, PropertiesVariant>& vals,
                           bool skipSignal)
        : Definitions(bus, path)
{
    for (const auto& v : vals)
    {
        setPropertyByName(v.first, v.second, skipSignal);
    }
}

[williamspatrick]

It is pretty straight-forward to switch that constructor's skipSignal parameter to be unused and switch the setPropertyByName call to always true. Any idea if any code it using that besides phosphor-inventory-manager? How do we test that we don't break anyone else's assumptions?

[mine260309]

It could be hard to figure out which code depends on this behavior.
It looks like to me that the code using Definitions should pass the skipSignal with expected value, instead of change the default behavior of sdbusplus.