{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":251596171,"defaultBranch":"master","name":"pfr-manager","ownerLogin":"openbmc","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-03-31T12:28:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13670043?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716919189.0","currentOid":""},"activityList":{"items":[{"before":"76b85dba1dc3e58fb35d740d3a0fa809b07a9113","after":"1695ee330bc54df35f537b4026bf1e2426ce9d28","ref":"refs/heads/master","pushedAt":"2024-09-03T15:20:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"clang-format: re-format for clang-18\n\nclang-format-18 isn't compatible with the clang-format-17 output, so we\nneed to reformat the code with the latest version. The way clang-18\nhandles lambda formatting also changed, so we have made changes to the\norganization default style format to better handle lambda formatting.\n\nSee I5e08687e696dd240402a2780158664b7113def0e for updated style.\nSee Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.\n\nChange-Id: Id77d01d036ba05e52cdda0e6c6fbc47842e9baf8\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"clang-format: re-format for clang-18"}},{"before":"ca8aaccfedeef801173433f50ca025848584a423","after":"76b85dba1dc3e58fb35d740d3a0fa809b07a9113","ref":"refs/heads/master","pushedAt":"2024-06-20T10:04:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Fix spelling mistakes using codespell\n\nThis commit corrects various spelling mistakes throughout the\nrepository. The corrections were made automatically using `codespell`[1]\ntool.\n\n[1]: https://github.com/codespell-project/codespell\n\nChange-Id: Ieb2858c33f2b872a4ba64b1e8f72f4a414b33b8e\nSigned-off-by: Manojkiran Eda ","shortMessageHtmlLink":"Fix spelling mistakes using codespell"}},{"before":"1388f6cf6c0e287331e5be6062bd0f58310e1bd0","after":"ca8aaccfedeef801173433f50ca025848584a423","ref":"refs/heads/master","pushedAt":"2024-06-20T09:44:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Modify BMC busy flag mailbox register value\n\nBMC busy period is the time for which BMC is busy (e.g. Flashing).\nPFR-Manager should not send the security packets to BMC during that\ninterval. This commit corrects the BMC Busy Mailbox register value\nto 0x80 as per the PFR HAS.\n\nTested:\nBefore update :\nroot@bmc-maca4bf018ce3a0:~#\n busctl call xyz.openbmc_project.PFR.Manager\n/xyz/openbmc_project/pfr xyz.openbmc_project.PFR.Mailbox\nReadMBRegister u 0x63\ny 0\n\nAfter update :\nroot@bmc-maca4bf018ce3a0:~#\nbusctl call xyz.openbmc_project.PFR.Manager\n/xyz/openbmc_project/pfr xyz.openbmc_project.PFR.Mailbox\nReadMBRegister u 0x63\ny 0x80\n\nChange-Id: I633a2d34dd889465309f7417f4e0e7c892d8d174\nSigned-off-by: Alex Antony \nSigned-off-by: Jayaprakash Mutyala ","shortMessageHtmlLink":"Modify BMC busy flag mailbox register value"}},{"before":"56b0e66dbabcb2910506ecaa6f33df1a7d58ff69","after":"1388f6cf6c0e287331e5be6062bd0f58310e1bd0","ref":"refs/heads/master","pushedAt":"2023-10-26T15:04:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"clang-format: copy latest and re-format\n\nclang-format-17 has some backwards incompatible changes that require\nadditional settings for best compatibility and re-running the formatter.\nCopy the latest .clang-format from the docs repository and reformat the\nrepository.\n\nChange-Id: Ib4c95a1751ec33461023d1ed5c225ee3d4df940e\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"clang-format: copy latest and re-format"}},{"before":"be13259dd6f1dc2fac52792be091c97d7223596f","after":"56b0e66dbabcb2910506ecaa6f33df1a7d58ff69","ref":"refs/heads/master","pushedAt":"2023-08-22T15:24:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Update the PFR CPLD Version format\n\n1. Removing the support of Main CPLD GPIO Lines as it was unused.\n The new format is -\n2. Updating the URI for cpld_active. The updated URI is -\n /redfish/v1/UpdateService/FirmwareInventory/rot_fw_active\n\nTested: Flashed the changes on the BMC.\n\nJournal logs from BMC -\njournalctl | grep pfr-manager\nroot@bmc-maca4bf018ceb52:~# journalctl | grep pfr-manager\nAug 10 12:08:23 bmc-maca4bf018ceb52 pfr-manager[535]: VERSION INFO - rot_fw_active - 3.0-0bbd19caa386faaa5802f21bc90ca557090413a788f9d098d5b346f08055c205\nAug 10 12:08:23 bmc-maca4bf018ceb52 pfr-manager[535]: VERSION INFO - bmc_recovery - 0.31-0-g1b1e1c\nAug 10 12:08:23 bmc-maca4bf018ceb52 pfr-manager[535]: VERSION INFO - rot_fw_recovery - 3.0\nAug 10 12:08:23 bmc-maca4bf018ceb52 pfr-manager[535]: Intel PFR service started successfully\n\nRedfish Logs with the updated URi -\n\n{\n \"@odata.id\": \"/redfish/v1/UpdateService/FirmwareInventory/rot_fw_active\",\n \"@odata.type\": \"#SoftwareInventory.v1_1_0.SoftwareInventory\",\n \"Description\": \"Other image\",\n \"Id\": \"rot_fw_active\",\n \"Name\": \"Software Inventory\",\n \"Status\": {\n \"Health\": \"OK\",\n \"HealthRollup\": \"OK\",\n \"State\": \"Enabled\"\n },\n \"Updateable\": false,\n \"Version\": \"3.0-0bbd19caa386faaa5802f21bc90ca557090413a788f9d098d5b346f08055c205\"\n}\n\nChange-Id: Iffde0324700b38ce01cd7fc3081c32000fbfc33a\nSigned-off-by: Ankita Prasad ","shortMessageHtmlLink":"Update the PFR CPLD Version format"}},{"before":"1218aa64d109facdd2633f1205e5e4f1be6d8891","after":"be13259dd6f1dc2fac52792be091c97d7223596f","ref":"refs/heads/master","pushedAt":"2023-08-18T08:12:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Set BMC boot complete checkpoint in unprovision mode\n\nIn non provisional mode, pfr service won't run because in pfr manager\ncode we are calling exit call to stop pfr service.\nCode modified when we recieved FinishTimestamp signal from systemd and\nthen checking provisional status if pfr is unprovisioned then calling\nexit call to stop pfr service.\n\nModified variable name from finishedSettingChkPoint to bmcBootCompleteChkPointDone\nModified function name setBMCBootCheckpoint to setBMCBootCompleteChkPoint\n\nTested:\nDuring unprovision and provision mode BMC checkpoint is setting to 0x09\n\nChange-Id: I91c1fc1d91a44b32ab94924f76b80c0a393ddde1\nSigned-off-by: sri anjaneyulu alapati ","shortMessageHtmlLink":"Set BMC boot complete checkpoint in unprovision mode"}},{"before":"48935a4343cbb81e43f37a9442d72905442300f9","after":"1218aa64d109facdd2633f1205e5e4f1be6d8891","ref":"refs/heads/master","pushedAt":"2023-08-04T09:40:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Removing PLD lines to read PFR CPLD Version\n\nPLD GPIO lines are no more supported to read the PFR CPLD version.\nHence, removing the PLD lines related changes. The new format of the PFR CPLD Version is - --\n\nTested: Flashed on BMC.\nBMC booted without any errors. pfr-manager not seeing the\nerror \"Failed to find the GPIO line\".\njournalctl | grep pfr-manager\nJul 28 04:21:26 bmc-mac562523846e69 pfr-manager[546]: VERSION INFO - cpld_active - 3.0-65a5bc415e9b2bab092351f74863ae6070ac3ef9e1be0ea83a4040aeaac52fcd\nJul 28 04:21:26 bmc-mac562523846e69 pfr-manager[546]: VERSION INFO - bmc_recovery - 0.27-30-g544234\nJul 28 04:21:26 bmc-mac562523846e69 pfr-manager[546]: VERSION INFO - cpld_recovery - 3.0\nJul 28 04:21:26 bmc-mac562523846e69 pfr-manager[546]: Intel PFR service started successfully\n\nChange-Id: I2de7f6ec8925308203577b49f1c4c3458072d967\nSigned-off-by: Ankita Prasad ","shortMessageHtmlLink":"Removing PLD lines to read PFR CPLD Version"}},{"before":"d5c499082f191ad729c034f955e0131c4c398f73","after":"48935a4343cbb81e43f37a9442d72905442300f9","ref":"refs/heads/master","pushedAt":"2023-06-30T21:11:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Use variable for service install location\n\nAfter enabling 'usrmerge', the install location for systemd service\nfiles changed. This uses a variable to get the installation location\ninstead of hardcoding it.\n\nTested:\nConfirmed that with 'usrmerge' enabled, the service file is correctly\ninstalled.\n\nChange-Id: I80eeca283ae4b7f58461b220ab7879ab3a150943\nSigned-off-by: Jason M. Bills ","shortMessageHtmlLink":"Use variable for service install location"}},{"before":"304e82e1a3a38c16cecffc169b47714153daa8b1","after":"d5c499082f191ad729c034f955e0131c4c398f73","ref":"refs/heads/master","pushedAt":"2023-06-21T11:50:26.477Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Updated Additional Error/Status codes\n\nThis commit adds new Error/Status codes under:\n1.Platform state map - Added Combined CPLD authenication,Combined CPLD image update\n Combined CPLD image recovery,Combined CPLD booted from Active CFM entries.\n\n2. Recovery reason map - Added BMC and CPU attestation failure entries\n\n3. Panic Reason map - Added Attestation failure entry.\n\n4. Major error code map - Added Attestation failure , Attestation challenge timeout,\n SPDM protocol timeout, memcpy Failed and Combined CPLD authenication failure entries.\n\nTested:\n- Manually triggered all the newly added events and observed the entry\n in redfish file(/var/log/redfish)\n- Event logs in web UI displayed the event correctly.\n Example:\n CPLD firmware resiliency error.\n Error reason: Combined CPLD Authentication failure (MinorCode:0x05).\n\n- GET on redfish/v1/Systems/system/LogServices/EventLog/Entries\n\n {\n \"@odata.id\": \"/redfish/v1/Systems/system/LogServices/EventLog/Entries/1686766462\",\n \"@odata.type\": \"#LogEntry.v1_9_0.LogEntry\",\n \"Created\": \"2023-06-14T18:14:22+00:00\",\n \"EntryType\": \"Event\",\n \"Id\": \"1686766462\",\n \"Message\": \"CPLD firmware resiliency error. Error reason: Combined CPLD authenication failure(MinorCode:0x05).\",\n \"MessageArgs\": [\n \"Combined CPLD authenication failure(MinorCode:0x05)\"\n ],\n \"MessageId\": \"OpenBMC.0.1.CPLDFirmwareResiliencyError\",\n \"Name\": \"System Event Log Entry\",\n \"Severity\": \"Critical\"\n },\n\nChange-Id: I60d9ec218cd9cab79e6d0598f9ee94bef0288015\nSigned-off-by: sri anjaneyulu alapati ","shortMessageHtmlLink":"Updated Additional Error/Status codes"}},{"before":"b29a15c60c97a518f6758dabce100893cdd6f35c","after":"304e82e1a3a38c16cecffc169b47714153daa8b1","ref":"refs/heads/master","pushedAt":"2023-06-16T16:53:47.779Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"clang-format: copy latest and re-format\n\nclang-format-16 has some backwards incompatible changes that require\nadditional settings for best compatibility and re-running the formatter.\nCopy the latest .clang-format from the docs repository and reformat the\nrepository.\n\nChange-Id: I8caffb39990bf9f0b54e6b1fee711e368a600b5c\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"clang-format: copy latest and re-format"}},{"before":"701084454224c4f30335293c40d03d8f046a8f39","after":"b29a15c60c97a518f6758dabce100893cdd6f35c","ref":"refs/heads/master","pushedAt":"2023-06-12T14:39:13.809Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"[pfr-manager]Implement BMCBusy Period\n\nBMC busy period is the time for which BMC is busy\n(e.g. Flashing).PFR-Manager should not send the security\npackets to BMC during that interval.\nThis patch introduces capability to intimate PFR about\nBMC busy period. Also ReadMBRegister D-Bus method is\nexposed in order to facilitate OEM IPMI commands to\nread the mail box register values\n\n\nTested:\nBoth the dbus methods InitiateBMCBusyPeriod and ReadMBRegister\nare working properly now. Logs below:\n\nroot@bmc-maca4bf018cc4b0:~# busctl call xyz.openbmc_project.PFR.Manager /xyz/openbmc_project/pfr xyz.openbmc_project.PFR.Mailbox ReadMBRegister u 0x63\ny 0\nroot@bmc-maca4bf018cc4b0:~# busctl call xyz.openbmc_project.PFR.Manager /xyz/openbmc_project/pfr xyz.openbmc_project.PFR.Mailbox InitiateBMCBusyPeriod b 1\nb true\nroot@bmc-maca4bf018cc4b0:~# busctl call xyz.openbmc_project.PFR.Manager /xyz/openbmc_project/pfr xyz.openbmc_project.PFR.Mailbox ReadMBRegister u 0x63\ny 1\nroot@bmc-maca4bf018cc4b0:~# busctl call xyz.openbmc_project.PFR.Manager /xyz/openbmc_project/pfr xyz.openbmc_project.PFR.Mailbox InitiateBMCBusyPeriod b 0\nb true\nroot@bmc-maca4bf018cc4b0:~# busctl call xyz.openbmc_project.PFR.Manager /xyz/openbmc_project/pfr xyz.openbmc_project.PFR.Mailbox ReadMBRegister u 0x63\ny 0\nroot@bmc-maca4bf018cc4b0:~#\n\nSigned-off-by: deepak kumar agrawal \nChange-Id: I47acf2a3cb220e55552685cc0eb1fccb2af8adfc","shortMessageHtmlLink":"[pfr-manager]Implement BMCBusy Period"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wM1QxNToyMDoyNS4wMDAwMDBazwAAAASrvTAi","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNi0xMlQxNDozOToxMy44MDk0ODJazwAAAAM_s6h2"}},"title":"Activity ยท openbmc/pfr-manager"}