Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAC algorithm done signal is correct? #365

Open
lmhmx opened this issue May 24, 2022 · 2 comments
Open

SAC algorithm done signal is correct? #365

lmhmx opened this issue May 24, 2022 · 2 comments

Comments

@lmhmx
Copy link

lmhmx commented May 24, 2022

In sac.py, line 304 "d = False if ep_len==max_ep_len else d", why d is set to False when the episode reach the max episode length? I think it should be "d = True if ep_len==max_ep_len else d"
@Ruyii2
Copy link

Ruyii2 commented Jun 12, 2024

do you have a good results by using the sac?

@Tilak1
Copy link

Tilak1 commented Aug 4, 2024

I am trying to run SAC as well. Did anyone get good results ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tilak1 @lmhmx @Ruyii2