Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix figure display, when using %matplotlib widget #432

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Nov 5, 2024

In general, using %matplotlib widget or %matplotlib ipympl should be almost equivalent (see matplotlib/ipympl#529). However, when using openPMD-viewer, the slider works fine when doing %matplotlib ipympl, but does not when doing %matplotlib widget (i.e. the figures are not displayed, when doing `%matplotlib widget).

This PR fixes the issue.

Copy link
Member

@dpgrote dpgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@RemiLehe RemiLehe merged commit 485b48c into dev Nov 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants