Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Enable audio denoise for OWT using a Wasm port of RNNoise Library #399

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arunetm
Copy link
Contributor

@arunetm arunetm commented Aug 15, 2020

This PR enables OWT to apply denoising to audio streams in the connection.

This is accomplished by porting the RNNoise NN based denoising library to WebAssembly and incorporating it to OWT audio stream processing. MediaStreams can be created with or without the denoising pipeline added.

PTAL

@arunetm
Copy link
Contributor Author

arunetm commented Aug 15, 2020

The details of failed CI tests appears to to inaccessible. How to view the logs?

src/sdk/base/denoise.js Outdated Show resolved Hide resolved
src/sdk/base/denoise.js Outdated Show resolved Hide resolved
src/sdk/base/denoise.js Outdated Show resolved Hide resolved
@arunetm
Copy link
Contributor Author

arunetm commented Oct 19, 2020

@taste1981 please review. The update moves implementation to use AudioWorklets as discussed.
The issue with mismatched sample buffer size between Audioworklet (128) and Rnnoise (>512) is resolved using a new ring buffer.

@taste1981
Copy link
Collaborator

@jianjunz please review this.

@jianjunz
Copy link
Collaborator

jianjunz commented Mar 1, 2021

It looks good to me. @taste1981, please check if the audio worklet has any license issue or code scan issue. If no, please merge this PR, thanks.

@taste1981
Copy link
Collaborator

It looks good to me. @taste1981, please check if the audio worklet has any license issue or code scan issue. If no, please merge this PR, thanks.

Unless the source code includes a copyright section as required by https://github.com/xiph/rnnoise 's copyright text, We should not allow this to be merged.

@arunetm
Copy link
Contributor Author

arunetm commented Mar 1, 2021

Thanks for the review. I will edit the source to meet the copyright requirements and update this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants