Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor fungibles impl #923

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

refactor fungibles impl #923

wants to merge 12 commits into from

Conversation

wangjj9219
Copy link
Contributor

No description provided.

@wangjj9219 wangjj9219 closed this Jun 14, 2023
@wangjj9219 wangjj9219 reopened this Jun 14, 2023
@wangjj9219 wangjj9219 changed the title refactor fungibles impl refactor fungibles impl[WIP] Jun 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #923 (e9b684d) into master (f7c8b38) will increase coverage by 0.22%.
Report is 2 commits behind head on master.
The diff coverage is 78.07%.

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   78.40%   78.63%   +0.22%     
==========================================
  Files         105      108       +3     
  Lines       10782    11387     +605     
==========================================
+ Hits         8454     8954     +500     
- Misses       2328     2433     +105     
Files Changed Coverage Δ
asset-registry/src/mock/para.rs 70.73% <ø> (ø)
currencies/src/lib.rs 48.36% <ø> (ø)
currencies/src/mock.rs 94.11% <ø> (ø)
payments/src/mock.rs 95.65% <ø> (ø)
traits/src/currency.rs 39.58% <0.00%> (ø)
xtokens/src/mock/para.rs 59.09% <ø> (ø)
xtokens/src/mock/para_relative_view.rs 24.39% <ø> (ø)
xtokens/src/mock/para_teleport.rs 15.78% <ø> (ø)
tokens/src/impls.rs 37.16% <41.76%> (+11.07%) ⬆️
tokens/src/impl_currency.rs 68.90% <68.90%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangjj9219
Copy link
Contributor Author

need to override the default impl of Unbalanced::increase_balance to support DustRemovalWhitelist, currently blocked by paritytech/substrate#14388

@xlc
Copy link
Member

xlc commented Jun 15, 2023

should try to integrate with those tests paritytech/substrate#13852

@wangjj9219 wangjj9219 changed the title refactor fungibles impl[WIP] refactor fungibles impl Aug 10, 2023
@xlc xlc requested a review from ermalkaleci August 11, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants