-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add ci #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjb0807
reviewed
May 14, 2024
zjb0807
approved these changes
May 15, 2024
frank0528
approved these changes
May 15, 2024
zjb0807
approved these changes
May 15, 2024
xlc
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_std
andstd
settings. I use#[allow(dead_code)]
or add conditional compilationcfg
to solve them. I am not sure if it's the recommend practice. It's really verbose sometimes. For example, inscale_info
crate, it's already usecfg_if
to ensure that the exported APIs are stable in bothstd
andno_std
environments. However, when we use it, we still need to add conditional compilation#[cfg(not(feature="std"))]
or#[allow(unused_imports)]
, otherwiseclippy
will complain.close #14