Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dll search path on windows via dedicated port #23

Merged
merged 13 commits into from
May 13, 2024
Merged

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Mar 13, 2024

Fixes #22

ports/python3/portfile.cmake Outdated Show resolved Hide resolved
@Neumann-A
Copy link
Member

i don't think this should have an extra port. Just make it part of python3

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Mar 13, 2024

The idea of this approach is, that it can replaced with a different directory layout and more startup customizations by users in an overlay.

@Neumann-A
Copy link
Member

The idea of this approach is, that it can replaced with a different directory layout and more startup customizations by users in an overlay.

This would still mean that it is a dependency of python3 and not a dependency somewhere downstream.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Mar 13, 2024

Yes, that can be done

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Mar 13, 2024

Hmm... PYTHON3_SITE is defined by python3 and we need this for the installation path

https://github.com/microsoft/vcpkg/blob/72c38122da5759ea515d01946512b2081914ad83/ports/python3/vcpkg-port-config.cmake#L1-L11

@Neumann-A
Copy link
Member

I think you can just hardcode the path since you don't have to care about linux or osx.

@m-kuhn m-kuhn force-pushed the py-add-vcpkg-dll-path branch 5 times, most recently from d1ba20f to 9588004 Compare May 13, 2024 06:45
@m-kuhn m-kuhn merged commit 93f4201 into main May 13, 2024
4 checks passed
@m-kuhn m-kuhn deleted the py-add-vcpkg-dll-path branch May 13, 2024 11:27
m-kuhn added a commit that referenced this pull request May 14, 2024
@m-kuhn m-kuhn mentioned this pull request May 14, 2024
m-kuhn added a commit that referenced this pull request May 14, 2024
m-kuhn added a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify init scripts on windows to add dll search directory.
2 participants