Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICMP Echo Request Semantics #1368

Open
newlandk opened this issue Aug 27, 2024 · 0 comments
Open

ICMP Echo Request Semantics #1368

newlandk opened this issue Aug 27, 2024 · 0 comments
Assignees
Labels
area:network area:os area:otel enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage

Comments

@newlandk
Copy link

newlandk commented Aug 27, 2024

Area(s)

area:network, area:os, area:otel

Is your change request related to a problem? Please describe.

There don't appear to be any ways to represent ICMP Echo (ping) in OTEL semantics today. The closest I've found is the Portable HTTP Synthetic Testing, so I've taken some inspiration from that and HTTP metrics to propose an option for feedback and further development.

Describe the solution you'd like

I would like to have a semantic for defining ICMP Echo Request/Reply (ping) response times.

I'm unsure what the top-level should be; possibly system as the request/response is usually being facilitated by the OS. For the time being I've put network as the top-level.

Metric Instrument Type Units Field Attributes Notes
network.icmpping.status Gauge 1 last server.address (echo responder), client.address (echo requester) Represents a singular echo request/response. 1/0 -> pass/fail. Additional attributes may be defined for failure mode.
network.icmpping.duration Gauge s (Seconds) last server.address (echo responder), client.address (echo requester) Represents a singular echo request/response. Response time in seconds. Additional attributes may be defined for failure mode.

Describe alternatives you've considered

Currently I've been using the default format that telegraf outputs, but am looking for something closer to what is represented here to standardize upon.

Additional context

I'm able to assist further development of this semantic and creating a PR if I can receive some guidance on whether this seems like an acceptable path forward. Thank you!

@newlandk newlandk added enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage labels Aug 27, 2024
@github-staff github-staff deleted a comment from YeGop0218 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:network area:os area:otel enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage
Projects
None yet
Development

No branches or pull requests

4 participants
@newlandk @arminru and others