Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: version control system (VCS) information: revision #1144

Closed
jschaf opened this issue Jun 11, 2024 · 4 comments
Closed

Proposal: version control system (VCS) information: revision #1144

jschaf opened this issue Jun 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jschaf
Copy link

jschaf commented Jun 11, 2024

Proposal: add vcs.revision as a semantic convention key.

It's often useful to add the version control revision, like a Git commit hash, to logs and traces that indicate the commit that the binary was built from. The vcs.revision is helpful to debug production issues.

As a counterpoint, service.version might already include the information or be detailed enough to identify the commit.

Complicating matters: should there also be vcs.repo to denote which repo the commit originated from?

@trask
Copy link
Member

trask commented Jun 11, 2024

related to #915

@arminru arminru added the enhancement New feature or request label Jun 18, 2024
@adrielp
Copy link
Contributor

adrielp commented Jul 16, 2024

We should also discuss whether or not vcs.repository.name should be a value or whether or not we should use an URI in its stead. Currently the working pull request adds vcs.repository.url.full to denote the address of the repository. See https://github.com/open-telemetry/semantic-conventions/pull/1075/files/2ece67333789008ab997552e4683f341d9916101#r1657015107

@adrielp
Copy link
Contributor

adrielp commented Nov 7, 2024

Relates to #1383 .

vcs.repository.ref.revision has now been moved to vcs.ref.{head,base}.revision in the above linked pull request.

vcs.repository.url.full is an attribute denoting the repository.

@jschaf - feel free to comment here on whether or not that helps/works. Happy to get feedback / discuss this further. I think the core attributes are there in the registry, but we haven't identified event/trace specifics, yet.

@adrielp adrielp self-assigned this Nov 7, 2024
@jschaf
Copy link
Author

jschaf commented Nov 7, 2024

Yep, works for me. Thank you for following up.

For feedback, the keys seem a touch wordy with repository, but that's pretty far into bike-shed territory.

@jschaf jschaf closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants