Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACKING: Stabilize instrument advisory parameter: "Attributes" #3751

Closed
trask opened this issue Oct 30, 2023 · 3 comments
Closed

TRACKING: Stabilize instrument advisory parameter: "Attributes" #3751

trask opened this issue Oct 30, 2023 · 3 comments
Assignees
Labels
spec:metrics Related to the specification/metrics directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal

Comments

@trask
Copy link
Member

trask commented Oct 30, 2023

What are you trying to achieve?

Stabilize Instrument advisory parameter: Attributes.

Additional context.

These advisory parameters are important for the Java Instrumentation, where we have a unified API for recording spans/metrics (e.g. HTTP server spans / HTTP server metrics), and so we pass in a single set of attributes (the span attributes), and use this advisory parameter when we construct the metrics in order to provide a default attribute filter, and then users can create a metric view to override the default and stamp more or less of the span attributes onto the metric.

@trask trask added the spec:metrics Related to the specification/metrics directory label Oct 30, 2023
@trask
Copy link
Member Author

trask commented Oct 30, 2023

Likely prototypes are the main blocker here. Have any other languages besides Java implemented this experimental advisory parameter yet? thx

@MrAlias
Copy link
Contributor

MrAlias commented Oct 30, 2023

Go has not implemented this yet.

@jsuereth jsuereth added the triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal label Nov 15, 2023
@jsuereth jsuereth changed the title Stabilize instrument advisory parameter: "Attributes" TRACKING: Stabilize instrument advisory parameter: "Attributes" Nov 15, 2023
@trask
Copy link
Member Author

trask commented Feb 9, 2024

oops, closing, looks like I opened two issues for this (#3785)

@trask trask closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal
Projects
None yet
Development

No branches or pull requests

4 participants