Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve histogram images in metrics data-model.md #3745

Open
breedx-splk opened this issue Oct 27, 2023 · 2 comments
Open

Improve histogram images in metrics data-model.md #3745

breedx-splk opened this issue Oct 27, 2023 · 2 comments
Labels
help wanted Extra attention is needed spec:metrics Related to the specification/metrics directory triage:accepted:ready

Comments

@breedx-splk
Copy link
Contributor

breedx-splk commented Oct 27, 2023

There are a handful of helpful images in the histogram readme that do a fantastic job of demonstrating how histograms work. Unfortunately, there are a couple of problems with these:

  1. The text aliasing looks awful / low quality text.
  2. The background is transparent, which means that the images are hard/impossible to see all the detail in dark mode.

I think it would be great if we could put a background color in place (to help both light and dark mode readers) and to maybe recreate these images as line art (svg) so the text is readable.

@jsuereth did you create these originally? If not, do you know who? I was thinking that starting with the original might be simpler than trying to completely recreate these.

Images in question live here:
https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/metrics/img

@breedx-splk breedx-splk added the spec:metrics Related to the specification/metrics directory label Oct 27, 2023
@tigrannajaryan
Copy link
Member

@breedx-splk do you want to work on this or looking for someone else to help with it?

Someone needs to track down who created the diagrams (use git blame?).

@breedx-splk
Copy link
Contributor Author

@breedx-splk do you want to work on this or looking for someone else to help with it?

I was not looking to pick this one up, just calling it out as an area for improvement. Thanks.

@tigrannajaryan tigrannajaryan added the help wanted Extra attention is needed label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed spec:metrics Related to the specification/metrics directory triage:accepted:ready
Projects
Status: Spec - Accepted
Development

No branches or pull requests

3 participants