Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify if OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE are required for new implementation #3717

Closed
pellared opened this issue Oct 12, 2023 · 0 comments · Fixed by #3719
Assignees
Labels
spec:protocol Related to the specification/protocol directory

Comments

@pellared
Copy link
Member

pellared commented Oct 12, 2023

What are you trying to achieve?

I want to stabilize the OTel Go OTLP metrics exporter.

**[2]**: The environment variables `OTEL_EXPORTER_OTLP_SPAN_INSECURE`
and `OTEL_EXPORTER_OTLP_METRIC_INSECURE` are obsolete because they do not follow
the common naming scheme of the other environment variables. They are still
supported because they were part of a stable release of the specification.

What is the intention behind using the term 'obsolete' in this context when the specification explicitly mandates support for both environment variables?

Use `OTEL_EXPORTER_OTLP_TRACES_INSECURE` instead of `OTEL_EXPORTER_OTLP_SPAN_INSECURE` and `OTEL_EXPORTER_OTLP_METRICS_INSECURE` instead of `OTEL_EXPORTER_OTLP_METRIC_INSECURE`.

What is the purpose of including this line if the specification dictates the continued support of the old environment variable?
Is this line primarily for user information? Is there any concern in using e.g. OTEL_EXPORTER_OTLP_SPAN_INSECURE if it remains stable and supported? Are there any intentions to discontinue or remove it in the future?

Additional context.

Based on the information provided in #2240, it appears that the author (@tsloughter) intended to convey that OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE are older environment variables, and if they were previously implemented, they should continue to be supported. It's implied that new implementations may not necessarily need to support OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE.

If that's the case, I believe we should aim for clearer wording. However, would this be regarded as an unacceptable breaking specification change or an acceptable fix? See #3719

@pellared pellared added the spec:protocol Related to the specification/protocol directory label Oct 12, 2023
@pellared pellared changed the title Clarify if OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE are required Clarify if OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE are required for new implementation Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:protocol Related to the specification/protocol directory
Projects
None yet
2 participants